Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RayCluster mTLS support #537

Merged
merged 7 commits into from Apr 19, 2024
Merged

Conversation

astefanutti
Copy link
Contributor

No description provided.

Copy link

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from astefanutti. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

(cherry picked from commit de2de96fc88022df783b637ccb145d1d73ba66ff)
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@VanillaSpoon VanillaSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Unsure how to avoid this error at setup for the CFO:

│ 2024-04-19T15:20:26Z    ERROR    cert-rotation    could not refresh CA and server certs 

But runs as expected.

@astefanutti
Copy link
Contributor Author

@VanillaSpoon the message is misleading but it worked.

@astefanutti astefanutti merged commit 1a0141e into project-codeflare:main Apr 19, 2024
12 of 15 checks passed
@astefanutti astefanutti deleted the pr-40 branch April 19, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants