Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align SDK with Validating Webhook behaviour on enableIngress #524

Merged
merged 1 commit into from
May 13, 2024
Merged

Align SDK with Validating Webhook behaviour on enableIngress #524

merged 1 commit into from
May 13, 2024

Conversation

ChristianZaccaria
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria commented Apr 26, 2024 •
edited

Issue link

Jira: https://issues.redhat.com/browse/RHOAIENG-6504

What changes have been made

  • Aligned the SDK with the behaviour in the Validating Webhook, specifically on the enableIngress field.

Verification steps

  • The user should be able to create a RayCluster resource via the SDK with enableIngress unset or set to false.
  • The user should not be able to create the RayCluster resource via the SDK with enableIngress set to true

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@ChughShilpa
Copy link
Contributor

Tested manually and it worked as expected.
Thanks Christian

Bobbins228
Bobbins228 reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@ChristianZaccaria
Copy link
Contributor Author

Rebased - Good for merge?

@ChughShilpa ChughShilpa self-requested a review May 7, 2024 10:04
@ChughShilpa
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@Bobbins228
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@Bobbins228
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a9bcce0 into project-codeflare:main May 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobbins228 Bobbins228 Bobbins228 left review comments

@anishasthana anishasthana Awaiting requested review from anishasthana

@ChughShilpa ChughShilpa Awaiting requested review from ChughShilpa

Assignees

@Bobbins228 Bobbins228

@ChughShilpa ChughShilpa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChristianZaccaria @ChughShilpa @Bobbins228