This repository was archived by the owner on Feb 18, 2025. It is now read-only.
add basic support for resource quota #45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronensc
reviewed
Dec 18, 2023
| state map[string]*QuotaState | ||
| } | ||
|
|
||
| // NewQuotaTracker : Create a new QuotaTracker |
There was a problem hiding this comment.
Suggested change
| // NewQuotaTracker : Create a new QuotaTracker | |
| // NewQuotaTracker creates a new QuotaTracker |
AFAIK, the convention in Go is that a doc comment of a func starts with a complete sentence that begins with the name of the element it describes.
ref: https://go.dev/blog/godoc
Although, it seems that this convention is not consistently used in this repo...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles phase 1 of issue #44 , namely Basic handling of quota resources {cpu, memory, ...}, {requests.cpu, requests.memory, ...} and {limits.cpu, limits.memory, ...}, including extended resources.