Updates to use a hardcoded port for the kubeproxy. #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
/test all |
…roxy --port=0'. This version doesn't hardcode the port making the code more reliable.
metalcycling
requested review from
Srihari1192
and removed request for
metalcycling and
astefanutti
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asm582 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metalcycling
added a commit
to metalcycling/multi-cluster-app-dispatcher
that referenced
this pull request
Jul 27, 2023
metalcycling
added a commit
to metalcycling/multi-cluster-app-dispatcher
that referenced
this pull request
Jul 27, 2023
metalcycling
added a commit
to metalcycling/multi-cluster-app-dispatcher
that referenced
this pull request
Jul 27, 2023
asm582
pushed a commit
that referenced
this pull request
Jul 27, 2023
…518) * Triggering different build * Checking if nodes can be listed * Trigger build * Resource patching. Extending resources of Kubernetes nodes to include 'fake' GPUs. * Fixed command to describe nodes * Kuttl tests for checking if GPUs we added correctly to the nodes * Fixed namespace issue and node name issue. * Adding all tests again now that the resource extension passes * Changed where the extended resources are tested * Added error checks for 'curl' calls. Rename variables to use lower case. * Fixed 'if' equal operator * Reopening PR #517 here to avoid naming issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Fixes #516
What changes have been made
Verification steps
Ran the script on my local development manchine.
Checks