remove threads, fix backoff #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astefanutti
reviewed
Sep 6, 2023
| if cond.Type == arbv1.AppWrapperCondBackoff { | ||
| //AWs that have backoff conditions have a delay of 10 seconds before getting added to enqueue. | ||
| //TODO: we could plug an interface here with back-off strategies for different MCAD use cases. | ||
| time.AfterFunc(time.Duration(cc.serverOption.BackoffTime)*time.Second, func() { |
There was a problem hiding this comment.
It'd be useful to have that logic encapsulated into a enqueueAfter method, so it mimics the semantic from client-go DelayingInterface.AddAfter, and can potentially be reused elsewhere.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
#618 #515
What changes have been made
Independent go routines performing backoff have been removed, and an informer has been used to re-queue AWs for backoff.
Verification steps
I have run manual tests to confirm that AW gets re-dispatched after configurable backoff seconds.
Checks