Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update aw examples for the kuberay integration doc #663

Merged

Conversation

tedhtchang
Copy link
Member

Issue link

What changes have been made

  • Update broken link
  • Update to Quay repo to avoid pull limit from dockerhub
  • Update resource in the appwrapper for the expect behavior to be observed in the demo use case

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@asm582
Copy link
Member

asm582 commented Oct 16, 2023

LGTM

@asm582
Copy link
Member

asm582 commented Oct 16, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@asm582
Copy link
Member

asm582 commented Oct 17, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 17, 2023
@openshift-ci openshift-ci bot merged commit b51df11 into project-codeflare:main Oct 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants