One approach to solve null values for subscription_name #4789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacciotti
added
the
smoke-tests
maskarb
reviewed
Nov 17, 2023
bacciotti
force-pushed
the
COST-4313-subscription-name-null
branch
from
9cdf0de to
5dfac9a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4789 +/- ##
=====================================
Coverage 94.0% 94.0%
=====================================
Files 365 365
Lines 30299 30310 +11
Branches 3603 3607 +4
=====================================
+ Hits 28478 28493 +15
+ Misses 1158 1156 -2
+ Partials 663 661 -2 |
lcouzens
previously approved these changes
Nov 20, 2023
|
Just need to bump that codecov if possible 👍 |
bacciotti
force-pushed
the
COST-4313-subscription-name-null
branch
3 times, most recently
from
2fe5186 to
af6f9c3
Compare
bacciotti
force-pushed
the
COST-4313-subscription-name-null
branch
from
b8ecd1a to
f86c0bb
Compare
|
/retest |
bacciotti
force-pushed
the
COST-4313-subscription-name-null
branch
2 times, most recently
from
1ab17a2 to
cd225b4
Compare
bacciotti
force-pushed
the
COST-4313-subscription-name-null
branch
from
f9dbcf5 to
bf3450a
Compare
|
lcouzens
approved these changes
Jan 3, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4313
Description
This change will replace the null values with
subscription_guidvalue.Testing
http://localhost:8000/api/cost-management/v1/reports/azure/costs/?group_by[subscription_guid]=*&filter[limit]=100subscription_namekeys