Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4481] use StringDtype(storage="pyarrow") #4826

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Dec 7, 2023

Jira Ticket

COST-4481

Description

Use StringDType with PyArrow for storage of string data to reduce overall memory consumption when splitting CSV files.

Closes #4805

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint or launch shell
    1. You should see ...
  4. Do more things...

Notes

...

@maskarb maskarb requested review from a team as code owners December 7, 2023 20:25
@maskarb maskarb added the smoke-tests pr_check will build the image and run minimal required smokes label Dec 7, 2023
@maskarb
Copy link
Member Author

maskarb commented Dec 7, 2023

/retest

@samdoran samdoran changed the title use StringDtype(storage="pyarrow") [COST-4481] use StringDtype(storage="pyarrow") Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #4826 (759f821) into main (61de77c) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4826   +/-   ##
=====================================
  Coverage   93.9%   93.9%           
=====================================
  Files        361     361           
  Lines      29900   29900           
  Branches    3562    3562           
=====================================
+ Hits       28076   28080    +4     
+ Misses      1162    1159    -3     
+ Partials     662     661    -1     

Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@maskarb maskarb enabled auto-merge (squash) December 7, 2023 20:42
@maskarb maskarb disabled auto-merge December 7, 2023 20:42
@maskarb maskarb enabled auto-merge (squash) December 7, 2023 20:43
@maskarb maskarb merged commit 9999949 into main Dec 7, 2023
10 checks passed
@maskarb maskarb deleted the use-StringDtype branch December 7, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants