[COST-3814] Check instanceid column instead of instancename #4835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgoodfred
added
the
azure-smoke-tests
maskarb
approved these changes
Dec 13, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4835 +/- ##
=====================================
Coverage 94.0% 94.0%
=====================================
Files 364 364
Lines 30204 30204
Branches 3598 3598
=====================================
+ Hits 28378 28380 +2
+ Misses 1165 1164 -1
+ Partials 661 660 -1 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-3814
Description
This change will search for the
instanceidcolumn as a backup forresourceidinstead ofinstancenamewhich matches what we do elsewhere with resource id's and Azure.Notes
...