-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-4389] Masu endpoint to convert parquet data types #4837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myersCody
changed the title
Cost 4389 fix parquet masu
[COST-4389] Masu endpoint to convert parquet data types
Dec 14, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4837 +/- ##
======================================
Coverage 94.0% 94.0%
======================================
Files 365 371 +6
Lines 30310 30680 +370
Branches 3607 3661 +54
======================================
+ Hits 28493 28848 +355
- Misses 1158 1167 +9
- Partials 659 665 +6 |
lcouzens
added
the
smoke-tests
pr_check will build the image and run minimal required smokes
label
Jan 4, 2024
/retest |
lcouzens
reviewed
Jan 5, 2024
lcouzens
removed
the
smoke-tests
pr_check will build the image and run minimal required smokes
label
Jan 8, 2024
myersCody
added
the
smoke-tests
pr_check will build the image and run minimal required smokes
label
Jan 9, 2024
/retest |
1 similar comment
/retest |
samdoran
reviewed
Jan 9, 2024
samdoran
reviewed
Jan 9, 2024
samdoran
reviewed
Jan 12, 2024
Co-authored-by: Sam Doran <sdoran@redhat.com>
samdoran
approved these changes
Jan 15, 2024
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4389
Description
This change will add an internal endpoint that downloads a parquet file from s3, reads the parquet schema from the local file, checks the data types, cast or transforms the data to the correct type, uploads the parquet file back up s3.
Testing
I have been running it by updating the the
make shell-schema
command:Note that the conversion was already marked as successful in the logs and no tasks were queued.
Notes
...