Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for AWS marketplace generator added ability to override product_name … #400

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

ddonahue007
Copy link
Contributor

@ddonahue007 ddonahue007 commented Jul 20, 2022

Added the ability to override 'product_name' & 'legal_entity' to AWS marketplace generator

When running the following commands with not specifying 'product_name' & 'legal_entity' in static.yaml file, you should see the default values be utilized.

default static file:

---
  generators:
    - MarketplaceGenerator:
        start_date: 2022-01-01
        processor_arch: 32-bit
        resource_id: 55555555
        product_sku: VEAJHRNKTJZQ
        region: us-east-1a
        tags:
          resourceTags/aws:createdBy: AssumedRole:AROAYSLL3JVQ6DYUNKWQJ:1637692740557658269
        instance_type:
          inst_type: m5.large
          vcpu: 2
          memory: '8 GiB'
          storage: 'EBS Only'
          family: 'General Purpose'
          cost: 1.000
          rate: 0.500

  accounts:
    payer: 9999999999999
    user:
      - 9999999999999
    currency_code: USD

nise report aws --static-report-file example_aws-marketplace_static_data.yml --aws-s3-report-name None --aws-s3-bucket-name ./local_providers/aws_local

results (snip-snaps)

default_legal_ent

default_product_name

override defaults values for 'product_name' & 'legal_entity' static file:

---
  generators:
    - MarketplaceGenerator:
        start_date: 2022-01-01
        processor_arch: 32-bit
        resource_id: 55555555
        product_sku: VEAJHRNKTJZQ
        product_name: 'TESTING'
        region: us-east-1a
        legal_entity: 'AWS DD'
        tags:
          resourceTags/aws:createdBy: AssumedRole:AROAYSLL3JVQ6DYUNKWQJ:1637692740557658269
        instance_type:
          inst_type: m5.large
          vcpu: 2
          memory: '8 GiB'
          storage: 'EBS Only'
          family: 'General Purpose'
          cost: 1.000
          rate: 0.500

  accounts:
    payer: 9999999999999
    user:
      - 9999999999999
    currency_code: USD

nise report aws --static-report-file example_aws-marketplace_static_data.yml --aws-s3-report-name None --aws-s3-bucket-name ./local_providers/aws_local

results (snip-snaps)

override_legal_ent

override_product_name

@ddonahue007 ddonahue007 self-assigned this Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #400 (05c7486) into main (58d65e2) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #400   +/-   ##
=====================================
  Coverage   93.9%   93.9%           
=====================================
  Files         57      57           
  Lines       4217    4226    +9     
  Branches     615     617    +2     
=====================================
+ Hits        3961    3970    +9     
  Misses       145     145           
  Partials     111     111           

@ddonahue007 ddonahue007 enabled auto-merge (squash) July 20, 2022 21:16
@ddonahue007 ddonahue007 merged commit 2cba7d7 into project-koku:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants