Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating readme files for ROS-OCP usage #433

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

dgaikwad
Copy link
Contributor

@dgaikwad dgaikwad commented Mar 9, 2023

No description provided.

@dgaikwad dgaikwad changed the title Updating read me files for ROS-OCP usage Updating readme files for ROS-OCP usage Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #433 (d51cc94) into main (31e5381) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #433     +/-   ##
=======================================
- Coverage   93.7%   93.7%   -0.0%     
=======================================
  Files         61      61             
  Lines       4492    4492             
  Branches     633     633             
=======================================
- Hits        4210    4209      -1     
- Misses       153     154      +1     
  Partials     129     129             

Copy link
Member

@maskarb maskarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just one comment:

@@ -1,3 +1,3 @@
__version__ = "4.0.2"
__version__ = "4.0.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because these changes only affect docs, we do not need to bump the version here. These docs don't go to pypi or anywhere outside of github.

@maskarb maskarb merged commit 05fa5ed into project-koku:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants