Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4869] add node, csi-driver, and csi-volume-handle to OCP storage reports #503

Merged
merged 13 commits into from
May 17, 2024

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented May 13, 2024

  • add node to OCP storage report
  • add csi-driver and csi-volume-handle to OCP storage report
  • enable ability to create pvc-less persistent volumes
  • we can also create rows with csi-driver and csi-volume-handle not populated by simple adding them to a static data file and leaving the value empty -> this is good for PVs created not using the csi drivers

Some testing:

  1. see populated May-2024-your-cluster-ocp_storage_usage.csv file:
$ nise report ocp -s 2024-05-01 --ocp-cluster-id your-cluster --write-monthly

this file is completely random
2. see populated May-2024-your-cluster-ocp_storage_usage.csv with static data and a claimless pv:

todo

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.6%. Comparing base (59bc0bb) to head (f51d81a).

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #503     +/-   ##
=======================================
+ Coverage   93.5%   93.6%   +0.1%     
=======================================
  Files         61      61             
  Lines       4649    4656      +7     
  Branches     655     656      +1     
=======================================
+ Hits        4348    4360     +12     
+ Misses       158     154      -4     
+ Partials     143     142      -1     

@maskarb maskarb changed the title [COST-4869] add csi-driver and csi-volume-handle [COST-4869] add node, csi-driver, and csi-volume-handle to OCP storage reports May 16, 2024
@myersCody myersCody merged commit 062f493 into main May 17, 2024
4 checks passed
@myersCody myersCody deleted the COST-4869-ocp-new-fields branch May 17, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants