-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Google Cloud Build to upload artifacts #253
Conversation
7abbbb5
to
f22c7b7
Compare
d594986
to
1a8575c
Compare
cloudbuild.yaml
Outdated
- name: 'gcr.io/cloud-builders/docker' | ||
id: pull_image | ||
waitFor: ['-'] | ||
timeout: 1h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this a bit too generous?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
id: move_artifacts | ||
waitFor: ['build_code'] | ||
entrypoint: 'cp' | ||
args: ['./bazel-bin/oak/server/asylo/oak_enclave_unsigned.so', './oak_enclave_unsigned.so'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... isn't there a way for bazel to specify the output of the binary instead of copying it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not AFAICT.
timeout: 2h | ||
|
||
options: | ||
machineType: 'N1_HIGHCPU_8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 8? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 CPUs 😎
Add an additional pipeline running on Google Cloud Build, which builds the enclave binary and pushes it to Google Cloud Storage. The intention is for this to be used to build reference binary artifacts to be deployed on Borg in Google if necessary, once we get full reproducible builds (#241). Always use Bazel cache for builds and for tests. Example run: https://pantheon.corp.google.com/cloud-build/builds/700d7aea-6799-4822-afa1-ec3758e88faf?project=oak-ci
1a8575c
to
2222f4e
Compare
Add an additional pipeline running on Google Cloud Build, which builds
the enclave binary and pushes it to Google Cloud Storage. The intention
is for this to be used to build reference binary artifacts to be
deployed on Borg in Google if necessary, once we get full reproducible
builds (#241).
Example run:
https://pantheon.corp.google.com/cloud-build/builds/700d7aea-6799-4822-afa1-ec3758e88faf?project=oak-ci