Windowed SCP with select
#152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bizarrely introduces some overhead which, despite numerous attempts to track down its source, has not entirely been eliminated. That said, it does bring the CPU load *way* down. Strangely, this patch negatively impacts write performance slightly (for both 0,0 and 1,1) and read performance for 0,0 but positively impacts read performance for 1,1. Further experimentation is required...
@mossblaser, I've fixed a broken test. There are still failing tests for you to investigate.
- Mocks out "select" so that it will work with mocks. - Changes tests to deal with slight change in send/receive operation.
`min` doesn't have a keyword `default` earlier than Python 3.4, this removes the requirement and adds a test that tests the newly added branch works correctly.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much @mossblaser's work, but I've gotten the tests to work fully. I'm happy to merge this in on top of my work on windowed SCP, but I'd like @mossblaser to have a look first.
Note: merges onto #117.