Add SpiNN-5 board geometry functions. #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds: * spinn5_eth_coords: Generate a list of board coordinates with Ethernet connectivity in a SpiNNaker machine. * spinn5_local_eth_coord: Get the coordinates of a chip's local ethernet connected chip. * spinn5_chip_coord: Get the coordinates of a chip on its board. * spinn5_fpga_link: Get the identity of the FPGA link which corresponds with the supplied link.
There was a problem hiding this comment.
Just so I understand: (4, 3) -> (0, 0)?
There was a problem hiding this comment.
So that lookup would return (-4, -3) for the key (4, 3) since the lookup gives the offset of the ethernet connected chip from the current chip. In this case it would indeed point at (0, 0) as the Ethernet connected chip.
I spent so long trying to find a closed-form version of this function and falling back on a LUT was very much a last resort (although the one used by ST and Luis).
|
LGTM. |
mossblaser
added a commit
that referenced
this pull request
Jul 30, 2015
Add SpiNN-5 board geometry functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
spinn5_eth_coords: Generate a list of board coordinates with Ethernetconnectivity in a SpiNNaker machine.
spinn5_local_eth_coord: Get the coordinates of a chip's local ethernetconnected chip.
spinn5_chip_coord: Get the coordinates of a chip on its board.spinn5_fpga_link: Get the identity of the FPGA link which corresponds withthe supplied link.
Some of this code is taken from the numerous defunct branches aiming to improve Ethernet performance by using multiple links.