Add corresponding __ne__ methods to objects with __eq__ #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are required for Python 2.7 compatibility: In Python 3.x if __ne__ is omitted, it defaults to the inversion of __eq__ if __eq__ defined. In Python 2.x __ne__ defaults to id(a) != id(b). Thanks to @alan-stokes for spotting this bug!
|
LGTM, the failing tests look like a connectivity issue. |
mossblaser
added a commit
that referenced
this pull request
Jan 28, 2016
Add corresponding __ne__ methods to objects with __eq__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are required for Python 2.7 compatibility: In Python 3.x if ne is
omitted, it defaults to the inversion of eq if eq defined. In Python
2.x ne defaults to id(a) != id(b).
Thanks to @alan-stokes for spotting this bug!