Skip to content

Conversation

mbshields
Copy link
Contributor

The substitution sections of these two files are now updated and in sync with each other. There is redundancy, but these two documents are likely to be arrived at from different circumstances -- one is part of the user guide and the other is a reference. This should address Issue #51

Signed-off-by: mbshields <mshields@alum.mit.edu>
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit de96fdb into project-stacker:main Apr 12, 2024
@mbshields mbshields deleted the docs_mishield_subs branch April 15, 2024 22:32

In the yaml directives, stacker allows variable substitions of several forms. For example, these three substition statements:

$ONE ${{TWO}} ${{THREE:3}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, we missed this part when I updated the stacker.yaml reference - we do not support $ONE anymore, it is OK to have that in the run section but it'll be interpreted as a shell variable by the shell running in the run section.
It will not be treated as a substitution, and if you run stacker build --substitute ONE=1 on this example you will get an error.

please see project-stacker/stacker#612 for my rewritten version of this in the source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants