fix: do not log found creds #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemccracken
requested review from
rchincha,
smoser and
hallyn
as code owners
ravi-ciroos
approved these changes
Oct 2, 2025
smoser
approved these changes
Oct 2, 2025
rchincha
reviewed
Oct 2, 2025
mikemccracken
force-pushed
the
2025.10.2/main/squelch-cred-logging
branch
from
348b400 to
ae6c890
Compare
mikemccracken
force-pushed
the
2025.10.2/main/squelch-cred-logging
branch
from
ae6c890 to
5537ba0
Compare
ravi-ciroos
approved these changes
Oct 2, 2025
rchamarthy
approved these changes
Oct 2, 2025
rchincha
approved these changes
Oct 2, 2025
we really shouldn't log the content of credentials Signed-off-by: Michael McCracken <mikmccra@cisco.com>
mikemccracken
force-pushed
the
2025.10.2/main/squelch-cred-logging
branch
from
5537ba0 to
90ec76c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
=======================================
Coverage 60.43% 60.43%
=======================================
Files 59 59
Lines 6491 6491
=======================================
Hits 3923 3923
Misses 1920 1920
Partials 648 648 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we really shouldn't log the content of credentials