feat(gql): add new query for diff of cves for 2 images #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentiuNiculae
requested review from
shimish2,
rchincha,
andaaron and
eusebiu-constantin-petu-dbk
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2185 +/- ##
==========================================
- Coverage 92.92% 92.86% -0.06%
==========================================
Files 165 165
Lines 21582 21837 +255
==========================================
+ Hits 20054 20280 +226
- Misses 952 969 +17
- Partials 576 588 +12 ☔ View full report in Codecov by Sentry. |
laurentiuNiculae
force-pushed
the
cve-diff-for-images
branch
5 times, most recently
from
4a85228
to
990f68e
Compare
andaaron
reviewed
Jan 26, 2024
laurentiuNiculae
force-pushed
the
cve-diff-for-images
branch
8 times, most recently
from
6cb2ae5
to
3960d51
Compare
|
@laurentiuNiculae in terms of priorities, make sure cli works first and then zui |
Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
laurentiuNiculae
force-pushed
the
cve-diff-for-images
branch
from
3960d51
to
4f81fd8
Compare
andaaron
reviewed
Feb 8, 2024
| } | ||
| } | ||
|
|
||
| func filterCVEList(cveMap []cvemodel.CVE, searchedCVE, excludedCVE string, pageFinder *CvePageFinder) { |
There was a problem hiding this comment.
Suggested change
| func filterCVEList(cveMap []cvemodel.CVE, searchedCVE, excludedCVE string, pageFinder *CvePageFinder) { | |
| func filterCVEList(cveList []cvemodel.CVE, searchedCVE, excludedCVE string, pageFinder *CvePageFinder) { |
| return true | ||
| } | ||
|
|
||
| return true |
There was a problem hiding this comment.
It is a bit strange, the logic above returns true if a condition is met, then it returns true in all remaining cases.
|
Superseded by #2242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.