Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cve): cli cve diff #2242

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

laurentiuNiculae
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

pkg/extensions/search/cve/cve.go Outdated Show resolved Hide resolved
pkg/extensions/search/resolver.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: Patch coverage is 92.92929% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 92.82%. Comparing base (752b9e8) to head (14884da).

Files Patch % Lines
pkg/cli/client/cves_sub_cmd.go 89.61% 4 Missing and 4 partials ⚠️
pkg/extensions/search/resolver.go 95.65% 4 Missing and 4 partials ⚠️
pkg/extensions/search/cve/cve.go 90.90% 3 Missing and 3 partials ⚠️
pkg/cli/client/search_functions.go 86.20% 2 Missing and 2 partials ⚠️
pkg/cli/client/service.go 91.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2242      +/-   ##
==========================================
+ Coverage   92.81%   92.82%   +0.01%     
==========================================
  Files         167      167              
  Lines       21855    22250     +395     
==========================================
+ Hits        20285    20654     +369     
- Misses        984      996      +12     
- Partials      586      600      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laurentiuNiculae
Copy link
Contributor Author

Example:
zli-linux-amd64 cve diff --url http://127.0.0.1:5000/ -u laur:password python:3.8.16-alpine3.17 python:3.8.16-alpine3.16

Should print CVE's in python:3.8.16-alpine3.17 and not in python:3.8.16-alpine3.16

Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the rename it looks good. Please add more tests to increase coverage

pkg/extensions/search/resolver.go Outdated Show resolved Hide resolved
pkg/extensions/search/resolver.go Show resolved Hide resolved
Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
@laurentiuNiculae laurentiuNiculae force-pushed the cli-cve-diff branch 2 times, most recently from 0183249 to b437bc0 Compare March 5, 2024 17:06
Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
@andaaron andaaron merged commit 5039128 into project-zot:main Mar 6, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants