Skip to content

Commit 842da0a

Browse files
yonghuahacrnsi
authored andcommitted
dm: cleanup assert in core.c
- check input by condition check, instead of assert. - remove redundant header file including for some files. Tracked-On: #3252 Signed-off-by: Yonghua Huang <yonghua.huang@intel.com> Reviewed-by: Shuo Liu <shuo.a.liu@intel.com>
1 parent 012ec75 commit 842da0a

File tree

9 files changed

+2
-9
lines changed

9 files changed

+2
-9
lines changed

devicemodel/core/vrpmb.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
#include <stdbool.h>
2929
#include <stdio.h>
3030
#include <string.h>
31-
#include <assert.h>
3231
#include <openssl/rand.h>
3332

3433
#include "types.h"

devicemodel/hw/pci/core.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2291,7 +2291,8 @@ pci_emul_cfgdata(struct vmctx *ctx, int vcpu, int in, int port, int bytes,
22912291
{
22922292
int coff;
22932293

2294-
assert(bytes == 1 || bytes == 2 || bytes == 4);
2294+
if ((bytes != 1) && (bytes != 2) && (bytes != 4))
2295+
return -1;
22952296

22962297
coff = cfgoff + (port - CONF1_DATA_PORT);
22972298
if (cfgenable) {

devicemodel/hw/platform/debugexit.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
* SUCH DAMAGE.
2525
*/
2626

27-
#include <assert.h>
2827
#include <stdbool.h>
2928
#include <stdio.h>
3029
#include <stdlib.h>

devicemodel/hw/platform/tpm/tpm.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
*/
77

88
#include <stdlib.h>
9-
#include <assert.h>
109
#include <stdio.h>
1110
#include <string.h>
1211
#include <stdbool.h>

devicemodel/hw/platform/tpm/tpm_crb.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
#include <stdlib.h>
1111
#include <stdbool.h>
1212
#include <string.h>
13-
#include <assert.h>
1413
#include <pthread.h>
1514

1615
#include "vmmapi.h"

devicemodel/hw/platform/tpm/tpm_emulator.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
#include <stdbool.h>
2020
#include <sys/stat.h>
2121
#include <fcntl.h>
22-
#include <assert.h>
2322

2423
#include "vmmapi.h"
2524
#include "tpm_internal.h"

devicemodel/hw/platform/usb_mouse.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
#include <stdio.h>
2929
#include <stdlib.h>
3030
#include <string.h>
31-
#include <assert.h>
3231

3332
#include "usb.h"
3433
#include "usbdi.h"

devicemodel/hw/platform/usb_pmapper.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
#include <pthread.h>
1010
#include <stdio.h>
11-
#include <assert.h>
1211
#include <string.h>
1312
#include <unistd.h>
1413
#include "usb.h"

devicemodel/hw/usb_core.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@
7676
*/
7777

7878
#include <sys/types.h>
79-
#include <assert.h>
8079
#include <stdio.h>
8180
#include <string.h>
8281
#include <fcntl.h>

0 commit comments

Comments
 (0)