Skip to content

Commit bad813e

Browse files
ZideChen0wenlingz
authored andcommitted
hv: fix MISRA-C violations in vpci code: Function pointer is of wrong type
576S: Function pointer is of wrong type. C90 requires the elements of an designated initializer to appear in a fixed order, the same as the order of declaration. C99 relaxes this rule but seems MISRA-C sticks to C90 in this regard. Tracked-On: #861 Signed-off-by: Zide Chen <zide.chen@intel.com> Acked-by: Anthony Xu <anthony.xu@intel.com> Reviewed-by: Huihuang Shi <huihuang.shi@intel.com>
1 parent d3f0edf commit bad813e

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

hypervisor/dm/vpci/hostbridge.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ static int vdev_hostbridge_cfgwrite(struct pci_vdev *vdev, uint32_t offset,
121121
struct pci_vdev_ops pci_ops_vdev_hostbridge = {
122122
.init = vdev_hostbridge_init,
123123
.deinit = vdev_hostbridge_deinit,
124-
.cfgread = vdev_hostbridge_cfgread,
125124
.cfgwrite = vdev_hostbridge_cfgwrite,
125+
.cfgread = vdev_hostbridge_cfgread,
126126
};
127127

hypervisor/dm/vpci/msi.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,6 @@ static int vmsi_deinit(struct pci_vdev *vdev)
223223
}
224224

225225
struct pci_vdev_ops pci_ops_vdev_msi = {
226-
.init = NULL,
227226
.deinit = vmsi_deinit,
228227
.cfgwrite = vmsi_cfgwrite,
229228
.cfgread = vmsi_cfgread,

hypervisor/dm/vpci/pci_pt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ static int vdev_pt_cfgwrite(struct pci_vdev *vdev, uint32_t offset,
198198
struct pci_vdev_ops pci_ops_vdev_pt = {
199199
.init = vdev_pt_init,
200200
.deinit = vdev_pt_deinit,
201-
.cfgread = vdev_pt_cfgread,
202201
.cfgwrite = vdev_pt_cfgwrite,
202+
.cfgread = vdev_pt_cfgread,
203203
};
204204

0 commit comments

Comments
 (0)