Skip to content

Commit e19dcf5

Browse files
binbinwu1wenlingz
authored andcommitted
hv: assign: fix MISRA-C violations on implicit type conversion
This patch fixes the MISRA-C violations in arch/x86/assign.c on implicit type conversion. Tracked-On: #861 Signed-off-by: Binbin Wu <binbin.wu@intel.com> Acked-by: Eddie Dong <eddie.dong@intel.com>
1 parent 714814f commit e19dcf5

File tree

1 file changed

+10
-15
lines changed

1 file changed

+10
-15
lines changed

hypervisor/arch/x86/assign.c

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ ptirq_build_physical_rte(struct acrn_vm *vm, struct ptirq_remapping_info *entry)
132132
union ioapic_rte virt_rte;
133133
bool phys;
134134

135-
vioapic_get_rte(vm, virt_sid->intx_id.pin, &virt_rte);
135+
vioapic_get_rte(vm, (uint32_t)virt_sid->intx_id.pin, &virt_rte);
136136
rte = virt_rte;
137137

138138
/* init polarity & pin state */
@@ -185,7 +185,7 @@ ptirq_build_physical_rte(struct acrn_vm *vm, struct ptirq_remapping_info *entry)
185185
/* just update trigger mode */
186186
ioapic_get_rte(phys_irq, &phys_rte);
187187
rte.full = phys_rte.full & (~IOAPIC_RTE_TRGRMOD);
188-
vpic_get_irq_trigger(vm, virt_sid->intx_id.pin, &trigger);
188+
vpic_get_irq_trigger(vm, (uint32_t)virt_sid->intx_id.pin, &trigger);
189189
if (trigger == LEVEL_TRIGGER) {
190190
rte.full |= IOAPIC_RTE_TRGRLVL;
191191
}
@@ -396,26 +396,22 @@ static void ptirq_handle_intx(struct acrn_vm *vm,
396396
bool trigger_lvl = false;
397397

398398
/* VPIN_IOAPIC src means we have vioapic enabled */
399-
vioapic_get_rte(vm, virt_sid->intx_id.pin, &rte);
399+
vioapic_get_rte(vm, (uint32_t)virt_sid->intx_id.pin, &rte);
400400
if ((rte.full & IOAPIC_RTE_TRGRMOD) == IOAPIC_RTE_TRGRLVL) {
401401
trigger_lvl = true;
402402
}
403403

404404
if (trigger_lvl) {
405405
if (entry->polarity != 0U) {
406-
vioapic_set_irq(vm, virt_sid->intx_id.pin,
407-
GSI_SET_LOW);
406+
vioapic_set_irq(vm, (uint32_t)virt_sid->intx_id.pin, GSI_SET_LOW);
408407
} else {
409-
vioapic_set_irq(vm, virt_sid->intx_id.pin,
410-
GSI_SET_HIGH);
408+
vioapic_set_irq(vm, (uint32_t)virt_sid->intx_id.pin, GSI_SET_HIGH);
411409
}
412410
} else {
413411
if (entry->polarity != 0U) {
414-
vioapic_set_irq(vm, virt_sid->intx_id.pin,
415-
GSI_FALLING_PULSE);
412+
vioapic_set_irq(vm, (uint32_t)virt_sid->intx_id.pin, GSI_FALLING_PULSE);
416413
} else {
417-
vioapic_set_irq(vm, virt_sid->intx_id.pin,
418-
GSI_RAISING_PULSE);
414+
vioapic_set_irq(vm, (uint32_t)virt_sid->intx_id.pin, GSI_RAISING_PULSE);
419415
}
420416
}
421417

@@ -431,12 +427,11 @@ static void ptirq_handle_intx(struct acrn_vm *vm,
431427
enum vpic_trigger trigger;
432428

433429
/* VPIN_PIC src means we have vpic enabled */
434-
vpic_get_irq_trigger(vm, virt_sid->intx_id.pin, &trigger);
430+
vpic_get_irq_trigger(vm, (uint32_t)virt_sid->intx_id.pin, &trigger);
435431
if (trigger == LEVEL_TRIGGER) {
436-
vpic_set_irq(vm, virt_sid->intx_id.pin, GSI_SET_HIGH);
432+
vpic_set_irq(vm, (uint32_t)virt_sid->intx_id.pin, GSI_SET_HIGH);
437433
} else {
438-
vpic_set_irq(vm, virt_sid->intx_id.pin,
439-
GSI_RAISING_PULSE);
434+
vpic_set_irq(vm, (uint32_t)virt_sid->intx_id.pin, GSI_RAISING_PULSE);
440435
}
441436
break;
442437
}

0 commit comments

Comments
 (0)