x86: lib: spin upon power off failure #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function exit() is not expected to return and can cause unpredictable behavior if it does instead. The current implementation attempts to power off the platform using multiple ways but assumes at least one of it succeeds, which is not the case atop ACRN hypervisor in partition mode. This patch adds a dead loop at the end of exit() to make sure that a unit-test spins when the platform cannot be powered off and causes no unwanted misbehavior. Signed-off-by: Junjie Mao <junjie.mao@intel.com>
fyin1-zz
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function exit() is not expected to return and can cause unpredictable
behavior if it does instead. The current implementation attempts to power off
the platform using multiple ways but assumes at least one of it succeeds, which
is not the case atop ACRN hypervisor in partition mode.
This patch adds a dead loop at the end of exit() to make sure that a unit-test
spins when the platform cannot be powered off and causes no unwanted misbehavior.
Signed-off-by: Junjie Mao junjie.mao@intel.com