This repository was archived by the owner on Oct 10, 2020. It is now read-only.
build-sys: Avoid self-dependency in setup.py #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rtnpro thoughts. |
|
@cgwalters change to use 1.2 and then I will merge for now. |
The earlier 58a6e0e and later 455fc84 both break if the atomic package is not actually installed on the system - as will be the case with `mock/pbuilder` style builds. It looks like OpenStack uses https://pypi.python.org/pypi/pbr which presumably solves this problem. I however am not super interested right now in diving into that...I just want the thing to build. Ansible just inserts the current dir in `sys.path`, which seems like a simple hack, so let's do that.
cgwalters
force-pushed
the
version-when-uninstalled
branch
from
d45c32d to
1068788
Compare
|
⬆️ reworks the patch to do what Ansible does. |
|
Until this lands I have frozen my internal CI/CD builds at 9186097 |
There was a problem hiding this comment.
@cgwalters Please remove the unused import: pkg_resources
|
@rhatdan @cgwalters Looks good to me, apart from the unused import of |
rhatdan
added a commit
that referenced
this pull request
Aug 14, 2015
build-sys: Avoid self-dependency in setup.py
|
I will remove the pkg_resources. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The earlier 58a6e0e and later
455fc84 both break if the atomic
package is not actually installed on the system - as will be the case
with
mock/pbuilderstyle builds.It looks like OpenStack uses https://pypi.python.org/pypi/pbr which
presumably solves this problem. I however am not super interested
right now in diving into that...I just want the thing to build.
So let's just hardcode the version number in two places for now.
Anyone who wants to improve this should probably look at PBR or
something other projects do.