Use a HashWithIndifferentAccess to contain configuration data

projectblacklight · Sep 30, 2022 · 88b3978 · 88b3978
1 parent ab71d7f
commit 88b3978
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/lib/blacklight/configuration/fields.rb b/lib/blacklight/configuration/fields.rb
@@ -13,7 +13,7 @@ module Fields
         def define_field_access(key, base_class_name = nil, class: nil)
           key = key.to_s if respond_to? :to_s
 
-          default_values[key.pluralize.to_sym] = ActiveSupport::OrderedHash.new
+          default_values[key.pluralize.to_sym] = ActiveSupport::HashWithIndifferentAccess.new
 
           @field_type_for_class ||= {}
           @field_type_for_class[key] = binding.local_variable_get(:class) || base_class_name

diff --git a/spec/models/blacklight/configuration_spec.rb b/spec/models/blacklight/configuration_spec.rb
@@ -39,13 +39,13 @@
     end
 
     it "has ordered hashes for field configuration" do
-      expect(config.facet_fields).to be_a_kind_of ActiveSupport::OrderedHash
-      expect(config.index_fields).to be_a_kind_of ActiveSupport::OrderedHash
-      expect(config.show_fields).to be_a_kind_of ActiveSupport::OrderedHash
-      expect(config.search_fields).to be_a_kind_of ActiveSupport::OrderedHash
-      expect(config.show_fields).to be_a_kind_of ActiveSupport::OrderedHash
-      expect(config.search_fields).to be_a_kind_of ActiveSupport::OrderedHash
-      expect(config.sort_fields).to be_a_kind_of ActiveSupport::OrderedHash
+      expect(config.facet_fields).to be_a_kind_of ActiveSupport::HashWithIndifferentAccess
+      expect(config.index_fields).to be_a_kind_of ActiveSupport::HashWithIndifferentAccess
+      expect(config.show_fields).to be_a_kind_of ActiveSupport::HashWithIndifferentAccess
+      expect(config.search_fields).to be_a_kind_of ActiveSupport::HashWithIndifferentAccess
+      expect(config.show_fields).to be_a_kind_of ActiveSupport::HashWithIndifferentAccess
+      expect(config.search_fields).to be_a_kind_of ActiveSupport::HashWithIndifferentAccess
+      expect(config.sort_fields).to be_a_kind_of ActiveSupport::HashWithIndifferentAccess
     end
   end