Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the type specific show field config #1975

Merged
merged 2 commits into from
Oct 4, 2018
Merged

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Oct 3, 2018

If you add configuration like:

    config.for_display_type 'Person' do
      config.add_show_field 'name_tsim', label: 'Name'
    end

Then, that config should be used to draw the pages that have documents
with that type.

@coveralls
Copy link

coveralls commented Oct 3, 2018

Coverage Status

Coverage increased (+0.02%) to 94.684% when pulling f14f1f0 on show-field-config into a43a0b1 on master.

If you add configuration like:
```ruby
    config.for_display_type 'Person' do
      config.add_show_field 'name_tsim', label: 'Name'
    end
```

Then, that config should be used to draw the pages that have documents
with that type.
@aaron-collier aaron-collier merged commit 0ac60aa into master Oct 4, 2018
@aaron-collier aaron-collier deleted the show-field-config branch October 4, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants