Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow search_builder_class to be passed to SearchService #2027

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Nov 7, 2018

So that this can be set without having to override SearchService. Since the SearchService is a new class in 7.0, this can be merged without concern for backward compatibility.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 94.742% when pulling b3d5304 on search-builder into 5284e21 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 94.742% when pulling b3d5304 on search-builder into 5284e21 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 94.742% when pulling b3d5304 on search-builder into 5284e21 on master.

@coveralls
Copy link

coveralls commented Nov 7, 2018

Coverage Status

Coverage remained the same at 94.743% when pulling bf728db on search-builder into 5284e21 on master.

@jcoyne jcoyne added this to the 7.0 milestone Nov 7, 2018
So that this can be set without having to override SearchService
@jcoyne jcoyne merged commit 663277f into master Nov 20, 2018
@jcoyne jcoyne deleted the search-builder branch November 20, 2018 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants