-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View component tools support #3106
View component tools support #3106
Conversation
Will this still work with view_component 2? The gemspec indicates that 2 is an acceptable version. |
I'm having a hard time figuring this out. The ViewComponent changelog for 3.0 lists this as a breaking change, but it seems this convention has been adopted throughout the rest of the Blacklight gem. For example |
@jcoyne , the gemspec requires at least view_component 2.66, not actually any 2. Line 34 in 8eb4d3a
The "newer" So should be good! |
Thank you for taking the lead on this @body-clock. I think I've incorporated all this into #3120 and merged into main. |
Addresses #3102
ViewComponent 3.0.0 switched the Slots API and how they're called. This PR addresses some code that had not been updated to reflect those changes. It also aims to test that the Tools components render their modals properly to prevent similar issues in the future.
Just one note - because the citation tool relies on methods not present in core Blacklight, the tool's functionality cannot test that the modal content renders correctly. I've chosen to just test that the header renders correctly. Through my investigation, I've also noticed that the Blacklight Demo doesn't have a working citation tool - something to think about.