Add [Symbol.iterator] to CachedAsyncIterable #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [Symbol.iterator] method returns a synchronous iterator over the elements cached by the CachedAsyncIterable instance.
|
@zbraniecki Would you like to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
[Symbol.iterator]method returns a synchronous iterator over the elements cached by theCachedAsyncIterableinstance. This is useful influent-reactwhere we can't really use the async iterable directly as it would create too many Promises, one for each<Localized>component. Instead,<Localized>can continue to usemapContextSyncto synchronously iterate over the already fetched contexts. When fallback might be required, it can calltouchNextto request the next context to be fetched.