Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No start override #562

Merged
merged 3 commits into from
Feb 15, 2020
Merged

No start override #562

merged 3 commits into from
Feb 15, 2020

Conversation

ederag
Copy link
Collaborator

@ederag ederag commented Feb 14, 2020

This is #491 again, supplemented with "if the parsed fact has no start, use now".
Should be better than #492,

fix #560 while keeping full backward compatibility with existing clients.

@jmberg the 10:00 meeting activity can be entered either by tricking
(e.g. prepending a character: .10:00 meeting),
or (that's new) by using double dashes -- as explicit missing times (see help).
Here That would be -- -- 10:00 meeting.

@mwilck Thanks for your test case in #491. Now the time would not be ignored,
so in some sense #492 was not, while this one is fully backward compatible.
If a client wants "activity without range" (not recommended at all),
it could just prepend -- -- to the string:
Screenshot_20200214_155923

Screenshot_20200214_155643

@ederag
Copy link
Collaborator Author

ederag commented Feb 14, 2020

0cffe9c reverted to allow testing only 😉

@mwilck
Copy link
Contributor

mwilck commented Feb 14, 2020

Thanks, this works better than before.

@GeraldJansen
Copy link
Contributor

Tested this also with xfce-hamster-plugin and "everything" (well, everything I tested) seems to be working fine now.

@ederag
Copy link
Collaborator Author

ederag commented Feb 15, 2020

Thanks !
Removed the revert, prior to merging.

@ederag ederag merged commit 95687ac into projecthamster:master Feb 15, 2020
@ederag ederag deleted the no-start-override branch February 15, 2020 13:30
@ederag ederag mentioned this pull request Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

start time ignored from xfce-hamster-plugin
3 participants