-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.0 #1707
Comments
@tpike3 I haven't been tracking as well as you. RE: Milestone - The milestone was called "next release" I renamed to v1.2.2, which we can change if you think it should be 1.3. Do the attached PRs look like everything between v1.2.1 & where we are now? |
There was 1 breaking change merged. I think we should merge the rest and push for 2.0. |
I forgot about the 2.0 merged stuff.. let's just do 2.0. |
i updated the title of this ticket.
|
We should deprecate |
I agree, we should deprecate and then create the notice and remove in 3.0 |
I think it's fine to keep |
Update on status: Last PR was merge... now history needs to be updated, merged, and we can deploy. |
Just when you think we are close... We have a problem with the release -- I got a HTTP 400 Error from test.pypi
Doing some reading on this, I feel like this is the best summary article & assuming that -- option 3 is what I am leaning towards. https://til.dchan.cc/posts/11-29-2022/ @rht - let me know your thoughts, other ideas? |
There are 2 options:
@Corvince objects to option 1, because only stable code should be in Mesa core. But this convention is not explicitly said nor known to the users. I have seen projects post 1.0 that adds experimental API/features (see e.g. Seaborn) just fine. The caveat of option 1 is that the models are not automatically included in the |
Ah, option 3 in that blog post is my option 2. |
Sorry, but I am super annoyed right now at you @rht . I know you have a long tradition of misinterpreting my comments, but I cannot possibly understand how you can turn
Into
Serious question, why are you doing this? On the topic: I think we should go for option 1 and 2. I think it makes more sense to have the Viz stuff inside the main repo. For now I would recommend to put it under an experimental module. That is |
Just read your own comment: #1726 (comment).
If that is not an objection, I don't know what it is. |
Let me try and summarize - @Corvince @rht I like the option 1 now (no issues with the experimental caveat until we smooth the edges) and option 2 in the near future to make the models more accessible. @jackiekazil let me know what you want do so we can get 2,0 out the door. |
@tpike3 ty for the summary... I had problems tracking. I am good with 1 now then 2 in future... and that will solve the error that I am getting? Let me know if there is anything I can do to help... review, etc |
Hello! Just to let you know I'm exploring the module. Today I noticed that the documentation says the jupyterViz is in mesa.visualization instead of experimental (still I found it thanks to this conversation). Thanks a lot for your work! |
@arielolafsalgado - can you file a ticket so we can fix the error? We just recently moved it from experimental to the default and there are some artifacts we still need to update. |
Last release was v1.21
Prep v2.0 Release
The text was updated successfully, but these errors were encountered: