-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set JupyterViz as stable #2090
Set JupyterViz as stable #2090
Conversation
Performance benchmarks:
|
Does this break existing models? |
This is an API breaking change because of the first commit. |
Good to know! Should we do it in two stages:
I might also be a proponent of just removing it in 3.0. You can always keep using the older versions if you want or need to. That keeps the codebase clean and lean. |
I think we can't include this in 2.3 since it's breaking. So we would add a warning for 2.3.0 that we will remove it in 3.0. @rht could you open a separate PR that adds a deprecation warning to the old visualisation? Then we can merge this PR as soon as 2.3 is branched - which will be this week. |
To be clear on the process: I would agree that we want to remove the old visualization code from the codebase entirely. But will add, don't we want push people to mesa-viz-tornado? Interestingly other people updated it in February - update As an aside always thinking about the ABM and Mesa ecosystem this add some intriguing questions on package management. |
2.3 is released, so we can start with 3.0 development work, including moving this PR forward! Deprecation warning for 2.3.x would still be nice though. |
Should I remove the Tornado viz altogether? This will free up the default dependencies and documentation. |
Performance benchmarks:
|
I'm good with that. Maybe we need to write a (short) migration guide for 3.0, and include a deprecation warning linking to it when trying to import the old tornado viz. |
I already wrote on Matrix several days ago
|
Right, then we do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like a second review on this, but from my perspective, this is good to go.
for more information, see https://pre-commit.ci
I'm merging now because if merge conflicts happen again, this is hard to redo. |
Agreed! Let’s continue to test and develop this, we have quite some time before 3.0 stable. |
This PR stabilizes the new Jupyter Visualisation. A new tutorial is available here: https://mesa.readthedocs.io/en/latest/tutorials/visualization_tutorial.html
If you already use the new visualisation, and want to keep using it, you need to change the import from
from mesa.experimental.jupyter_viz import JupyterViz
tofrom mesa.visualization.jupyter_viz import JupyterViz
If you want to want to keep using the old visualisation, you can do so by using the Mesa 2.3.x releases. Mesa 3.0 won't be supporting it.