Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to kustomize based rendering #67

Merged
merged 6 commits into from
Nov 9, 2022
Merged

Switch to kustomize based rendering #67

merged 6 commits into from
Nov 9, 2022

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Nov 7, 2022

This PR switches from a manual patching of upstream resources to a kustomize based setup.

The diff is a mess, as the indentation for arrays changes for multiple resources. The following diff is a bit more useful:
https://github.com/projectsyn/component-kyverno/pull/67/files/8b39f89f33a6b16e17b25134096c0af15d6cbe42
(The two commits for this will be removed before merging)

This brings a few new clusterroles, changes some labels, and brings a minor config change, which AFAICT doesn't change much.

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@glrf glrf force-pushed the change/kustomize branch from bb5fed9 to 72df719 Compare November 7, 2022 16:14
@glrf glrf self-assigned this Nov 7, 2022
@glrf glrf force-pushed the change/kustomize branch 5 times, most recently from 03797e3 to b5f9010 Compare November 8, 2022 09:37
@glrf glrf added the change label Nov 8, 2022
@glrf glrf force-pushed the change/kustomize branch from 135ebf1 to 16078ee Compare November 9, 2022 09:45
@glrf glrf force-pushed the change/kustomize branch from 16078ee to 91483d4 Compare November 9, 2022 10:27
glrf added 3 commits November 9, 2022 11:50
Due to a bug in gitpython 3.1.24 commodore is not able to show diffs
when there are changed files with colons. We work arround this issue by
renaming these files.
@glrf glrf force-pushed the change/kustomize branch from 91483d4 to fb2017e Compare November 9, 2022 10:51
@glrf glrf marked this pull request as ready for review November 9, 2022 10:53
@glrf glrf requested review from simu and bastjan November 9, 2022 10:53
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

glrf and others added 2 commits November 9, 2022 13:20
Co-authored-by: Sebastian Widmer <sebastian.widmer@vshn.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants