-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to kustomize based rendering #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb5fed9
to
72df719
Compare
03797e3
to
b5f9010
Compare
135ebf1
to
16078ee
Compare
16078ee
to
91483d4
Compare
Due to a bug in gitpython 3.1.24 commodore is not able to show diffs when there are changed files with colons. We work arround this issue by renaming these files.
This reverts commit b5f9010.
91483d4
to
fb2017e
Compare
simu
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bastjan
approved these changes
Nov 9, 2022
Co-authored-by: Sebastian Widmer <sebastian.widmer@vshn.net>
67967b7
to
5bd1470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from a manual patching of upstream resources to a kustomize based setup.
The diff is a mess, as the indentation for arrays changes for multiple resources. The following diff is a bit more useful:
https://github.com/projectsyn/component-kyverno/pull/67/files/8b39f89f33a6b16e17b25134096c0af15d6cbe42
(The two commits for this will be removed before merging)
This brings a few new clusterroles, changes some labels, and brings a minor config change, which AFAICT doesn't change much.
Checklist
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog.