Skip to content

Use makeMergeable helper to deep-merge overrides #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Use makeMergeable helper to deep-merge overrides #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- Keep the empty manifest directory ([#3])
- Deep-merging of StorageClass overrides ([#6])

[Unreleased]: https://github.com/projectsyn/component-storageclass/compare/76db758a57b9dc33b95abf0a1bd7a21ce1ac185a...HEAD
[#1]: https://github.com/projectsyn/component-storageclass/pull/1
[#2]: https://github.com/projectsyn/component-storageclass/pull/2
[#3]: https://github.com/projectsyn/component-storageclass/pull/3
[#4]: https://github.com/projectsyn/component-storageclass/pull/4
[#6]: https://github.com/projectsyn/component-storageclass/pull/6
3 changes: 2 additions & 1 deletion component/main.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
local com = import 'lib/commodore.libjsonnet';
local kap = import 'lib/kapitan.libjsonnet';
local kube = import 'lib/kube.libjsonnet';
local inv = kap.inventory();
Expand All @@ -7,7 +8,7 @@ local params = inv.parameters.storageclass;

{
[name]:
sc.storageClass(name) + params.classes[name]
sc.storageClass(name) + com.makeMergeable(params.classes[name])
for name in std.objectFields(params.classes)
} + {
[if std.length(params.classes) == 0 then '.gitkeep']: {},
Expand Down