Ensure only one SC is marked as "default" #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhutter
changed the title
If there are multiple storageclasses that have the "is-default-class" annotation set to 'true', provisioning new PVs will fail for PVCs without an explicit SC set. This commit aims to ensure that said annotation is automatically removed from classes that are managed by Syn but are NOT the default. Signed-off-by: Manuel Hutter <manuel@hutter.io>
mhutter
force-pushed
the
feat/unset-default
branch
from
ff8ca17 to
c5cb40a
Compare
simu
approved these changes
May 31, 2021
simu
added a commit
that referenced
this pull request
Jun 15, 2021
This should ensure that ArgoCD can sync non-default storageclasses correctly. Fixes the change introduced in #7.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are multiple storageclasses that have the "is-default-class"
annotation set to 'true', provisioning new PVs will fail for PVCs
without an explicit SC set.
This commit aims to ensure that said annotation is automatically removed
from classes that are managed by Syn but are NOT the default.
Checklist