Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jsonnet Best Practices #86

Merged
merged 4 commits into from
Sep 11, 2020
Merged

Jsonnet Best Practices #86

merged 4 commits into from
Sep 11, 2020

Conversation

srueg
Copy link
Contributor

@srueg srueg commented Sep 4, 2020 •
edited
Loading

Checklist

  • Keep pull requests small so they can be easily reviewed.

@srueg srueg mentioned this pull request Sep 4, 2020
Open
11 tasks
@srueg srueg force-pushed the explanation/jsonnet branch 2 times, most recently from dc77d89 to 63eef74 Compare September 9, 2020 09:54
@srueg srueg marked this pull request as ready for review September 9, 2020 09:54
@srueg srueg requested a review from corvus-ch September 9, 2020 11:15
@srueg srueg force-pushed the explanation/jsonnet branch from 63eef74 to 3bcc43b Compare September 9, 2020 11:16
@srueg srueg requested a review from simu September 9, 2020 11:19
simu
simu approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far

@srueg
Copy link
Contributor Author

srueg commented Sep 9, 2020

I'd propose to merge this as is and create new PRs for the other topics.

@simu
Copy link
Member

simu commented Sep 9, 2020

Works for me

corvus-ch
corvus-ch suggested changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@corvus-ch corvus-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree to merge this while not all sections are written. However, the current text needs some more love.

docs/modules/ROOT/pages/explanations/jsonnet.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/explanations/jsonnet.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/explanations/jsonnet.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/explanations/jsonnet.adoc Outdated Show resolved Hide resolved
@srueg srueg force-pushed the explanation/jsonnet branch from 3bcc43b to f1feeba Compare September 10, 2020 07:59
@srueg srueg requested a review from corvus-ch September 10, 2020 07:59
@srueg srueg force-pushed the explanation/jsonnet branch from f1feeba to 2e2b8ab Compare September 10, 2020 12:21
@srueg srueg merged commit 2f7cc5b into master Sep 11, 2020
@srueg srueg deleted the explanation/jsonnet branch September 11, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corvus-ch corvus-ch corvus-ch approved these changes

@simu simu simu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srueg @simu @corvus-ch