Skip to content

Conversation

dpavlos
Copy link
Contributor

@dpavlos dpavlos commented Feb 20, 2020

Hello and thanks for this great exporter! I have noticed that there is a typo in elasticsearch_jvm_gc_collection_seconds_count metric which actually counts gc events and not seconds.

@dpavlos
Copy link
Contributor Author

dpavlos commented Mar 4, 2020

Any chance of reviewing this? @zwopir @pakohan Thanks in advance!

Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants