Exclude pg_settings_* on --disable-default-metrics #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using --disable-default-metrics, I expect postgres_exporter to provide _no_ metrics besides those explicitly requested with --extend.query-path. See prometheus-community#168 (comment)
|
I just saw a similar thing has already implemented in #223. My preference would be to not introduce a new flag: the common use cases I can think of involve either wanting all the default metrics, or none of them. No reason to treat settings specially. |
|
I agree @bitglue on this - I can't see a reason to make this super-granular (Prometheus can be configured to drop metrics anyway). |
|
We've set up an autobuild that builds v0.4.7 with this pr cherry picked on top: corvana/postgres-exporter:v0.4.7-no-pg-settings This is required for us to be able to scrape greenplum. |
|
This feature is introduced by #215 is now merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using --disable-default-metrics, I expect postgres_exporter to
provide no metrics besides those explicitly requested with
--extend.query-path.
See #168 (comment)