Vendoring + cross compilation = missing procfs.Proc.NewStat

[piotrkowalczuk]

Hi,

I'm trying to compile project on OS X for docker container:

$ CGO_ENABLED=0 GOOS=linux go build -v -ldflags "${LDFLAGS}" -o .publish/${SERVICE}d ${CMD}

Sadly I'm getting such issue:

# 
<project-path>/vendor/github.com/prometheus/client_golang/prometheus
vendor/github.com/prometheus/client_golang/prometheus/process_collector.go:119: p.NewStat undefined (type procfs.Proc has no field or method NewStat)
net/http/pprof

It looks similar to the #68 . I'm using package in version v0.7.0. This version is vendoring a procfs package that use CGO (https://github.com/prometheus/client_golang/tree/0.7.0/Godeps/_workspace/src/github.com/prometheus/procfs)

- package: github.com/prometheus/client_golang
  version: ~0.7.0
  subpackages:
  - prometheus

Glide is taking automatically version from Godeps.

[beorn7]

@grobie Do you understand what's going on here?

[grobie]

I don't. Looking at the vendored package, the function is defined there https://github.com/prometheus/client_golang/blob/0.7.0/Godeps/_workspace/src/github.com/prometheus/procfs/proc_stat.go#L79.

The 0.7.0 tag differs a lot from master, it doesn't longer vendor dependencies (as it is a library). @piotrkowalczuk can you still reproduce the issue? Did you try the master version as well?

[grobie]

Glide automatically chooses the 0.7.0 release of client_golang. Using master has been confirmed to fix the issue.

@beorn7 People will continue to run into this issue as long as the latest release includes Godeps and outdated vendored versions of procfs.

[beorn7]

I'll planning to send out a PR for public registry over the weekend.
If that results in endless discussion, we can release the current state.
Otherwise, we can release with the public registry. There are almost no breaking changes planned.

[grobie]

Sounds great! Looking forward to the registry.

On Thu, Jul 28, 2016 at 4:08 PM, Björn Rabenstein notifications@github.com
wrote:

I'll planning to send out a PR for public registry over the weekend.
If that results in endless discussion, we can release the current state.
Otherwise, we can release with the public registry. There are almost no
breaking changes planned.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#206 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAANaG_KreFtO_YqRnWSFqOUuxUAbLh-ks5qaQxQgaJpZM4I7iCS
.

[beorn7]

I plan to release 0.8 once #221 is merged.

[beorn7]

Done. Closing.