s/ext/pbutil/g #106
Merged
s/ext/pbutil/g #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency matttproud/golang_protobuf_extensions changed its package layout and thereby broke the Prometheus client_golang build. This fixes it.
This was referenced Apr 7, 2015
Closed
Godeps/Godeps.json
Outdated
There was a problem hiding this comment.
Hmm... why is ext still referenced here? It should be gone for good, shouldn't it?
There was a problem hiding this comment.
Yes, it should be. I'm not sure how to remove it via the godep tool; I'll remove it manually.
There was a problem hiding this comment.
Ugh... godeps doesn't want us to edit that file manually, but apparently you have to... weirdness continues...
|
LGTM! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency matttproud/golang_protobuf_extensions changed its package layout with this commit and thereby broke the Prometheus client_golang build. This fixes it.