Skip to content

Replace hidden label prefix with meta prefix. #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2015
Merged

Replace hidden label prefix with meta prefix. #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions model/labelname.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ const (
// label names.
ReservedLabelPrefix = "__"

// HiddenLabelPrefix is a prefix which is legal in user-supplied label names
// but will not appear in the eventual metrics.
// Reserved labels may be excepted from that rule.
HiddenLabelPrefix = "_"
// MetaLabelPrefix is a prefix for labels that provide meta information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add something like "...that provide meta-information useful during target relabeling, but will not be attached to time series themselves."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certain yes to the final part. Meta is completely generic though and we might use it outside of SD/relabelling in the future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

// Labels with this prefix are used for intermediate label processing and
// will not be attached to time series.
MetaLabelPrefix = "__meta_"

// JobLabel is the label name indicating the job from which a timeseries
// was scraped.
Expand Down