Fingerprinting fixes in client_golang #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move everything over to a more expensive but less collision-prone way. However, keep the old fingerprinting under the name "FastFingerprint" to be used in the storage layer (where we need collision detection anyway).
model/metric.go
Outdated
There was a problem hiding this comment.
I screwed up here anyway, should be superset, not subset... will reword...
|
👍 besides nits |
|
👍 |
beorn7
added a commit
that referenced
this pull request
May 6, 2015
Fingerprinting fixes in client_golang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@juliusv These are the fixes we need in client_golang. prometheus/prometheus code that uses these fixes needs to be changed to not change the fingerprint used in storage.
(Separate PR imminent.)