feat(dependency): replace go-spew package

[dongjiang1989]

use godebug package replace go-spew package

fix: #1490

[dongjiang1989]

@kakkoyun PTAL

/cc @anurag-deshpande

[kakkoyun]

Thanks a lot for handling this.

I wonder how hard this is even without using a transitive dependency.

Could you maybe give it another shot with the standard library testing package?

[dongjiang1989]

Thanks a lot for handling this.

I wonder how hard this is even without using a transitive dependency.

Could you maybe give it another shot with the standard library testing package?

Thanks for your review. Hmmm... Maybe not Diff string with the standard library testing package.

Like:

-(bytes.Buffer) # HELP some_other_metric A value that represents a counter.
-# TYPE some_other_metric counter
-some_other_metric{label1="value1"} 1
+(bytes.Buffer) # HELP some_total A value that represents a counter.
+# TYPE some_total counter
+some_total{label1="value1"} 1

[kakkoyun]

It's great that the test are green now. But we are losing some information.

I'd suggest adding the following file with proper licence headers to the testutils package https://github.com/kylelemons/godebug/blob/master/diff/diff.go

https://pkg.go.dev/github.com/kylelemons/godebug@v1.1.0/diff

And updating the tests accordingly.

Or go back the previous version where you used go-cmp.

In any case, good job. You're close :)

[dongjiang1989]

It's great that the test are green now. But we are losing some information.

I'd suggest adding the following file with proper licence headers to the testutils package https://github.com/kylelemons/godebug/blob/master/diff/diff.go

https://pkg.go.dev/github.com/kylelemons/godebug@v1.1.0/diff

And updating the tests accordingly.

Or go back the previous version where you used go-cmp.

In any case, good job. You're close :)

Thanks for your review. Please recheck :)

[kakkoyun]

Great job 👏

Only one last thing.

I'd suggest adding the following file with proper licence headers to the testutils package https://github.com/kylelemons/godebug/blob/master/diff/diff.go

In my previous comment, I suggested copying over the diff.go file from this repo rather than adding as a dependency. Remember our goal is to reduce the dependencies. Since it's a single file and simple enough. We can just copy the files (with licence headers) into the testutils package.

[dongjiang1989]

Great job 👏

Only one last thing.

I'd suggest adding the following file with proper licence headers to the testutils package https://github.com/kylelemons/godebug/blob/master/diff/diff.go

In my previous comment, I suggested copying over the diff.go file from this repo rather than adding as a dependency. Remember our goal is to reduce the dependencies. Since it's a single file and simple enough. We can just copy the files (with licence headers) into the testutils package.

Got it. Thanks. Fixed