Skip to content

chore: Drop support for <go1.22 #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2025
Merged

chore: Drop support for <go1.22 #1862

merged 1 commit into from
Aug 26, 2025

Conversation

mrueg
Copy link
Contributor

@mrueg mrueg commented Aug 25, 2025

Drops a bunch of files for outdated go versions that are not supported anymore.

@mrueg mrueg force-pushed the drop-old-goversion branch from 384df65 to 2a927e2 Compare August 25, 2025 09:13
kakkoyun
kakkoyun reviewed Aug 25, 2025
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to keep a "soft" support for older versions, until we actually break things in somewhere common for older version.

That being said I would be happy to drop anything older than 1.22

@kakkoyun
Copy link
Member

The idea was to keep a "soft" support for older versions, until we actually break things in somewhere common for older version.

That being said I would be happy to drop anything older than 1.22

What do you think? @bwplotka @ArthurSens @vesari

@mrueg mrueg force-pushed the drop-old-goversion branch 2 times, most recently from dc87f24 to 8c1d3a7 Compare August 25, 2025 19:10
@mrueg mrueg changed the title chore: Drop support for <go1.23 chore: Drop support for <go1.22 Aug 25, 2025
@mrueg
chore: Drop support for <go-1.22
fc9afc7 
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
@mrueg mrueg force-pushed the drop-old-goversion branch from 8c1d3a7 to fc9afc7 Compare August 25, 2025 19:10
@mrueg
Copy link
Contributor Author

mrueg commented Aug 25, 2025

Works for me, I readded the go 1.22 bits.

bwplotka
bwplotka approved these changes Aug 26, 2025
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

My vote would be to drop everything that is not explicitly build in our CI, otherwise we don't know if what we maintain is really usable 🙈 (so why maintaining that then). Not a super strong opinion, not a biggie to keep 1.22 -- thanks!

@bwplotka bwplotka merged commit 493c96a into prometheus:main Aug 26, 2025
8 checks passed
@kakkoyun
Copy link
Member

Thanks!

My vote would be to drop everything that is not explicitly build in our CI, otherwise we don't know if what we maintain is really usable 🙈 (so why maintaining that then). Not a super strong opinion, not a biggie to keep 1.22 -- thanks!

Fair! We can do this to make it straight-forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun left review comments

@bwplotka bwplotka bwplotka approved these changes

@ArthurSens ArthurSens Awaiting requested review from ArthurSens ArthurSens is a code owner

@vesari vesari Awaiting requested review from vesari vesari is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrueg @kakkoyun @bwplotka