bug(remote_write): Fix compression buffer pooling #1889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpetkovski
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
The compressed buffer is released before the request is made, which leads to corrupted remote-write payloads being sent to the target. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
fix-buffer-management
branch
from
915dc2d to
382efef
Compare
|
Thanks! |
|
Although.. some unit test would be nice so we don't repeat this mistake (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compressed buffer is released before the request is made, which leads to corrupted remote-write payloads being sent to the target.
The compression function uses the pattern where the destination slice can be passed in, and the function returns a reference to it, adjusted for length.