Add a concurrent end-to-end test for observe-register-gather #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 10, 2018 15:41
Signed-off-by: beorn7 <beorn@soundcloud.com>
This is an attempt to expose istio/istio#8906 . The failure to do so makes me believe the error is either already fixed in current client_golang, or something weird I haven't spotted yet is happening in the istio code. Signed-off-by: beorn7 <beorn@soundcloud.com>
stuartnelson3
approved these changes
Oct 10, 2018
|
Precisely. I could of course rebase this branch on top of master, but then everything else I had branched off this branch would be even more of a mess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@douglas-reid @bobbytables this should test what you are doing in istio. Failure to fail here tells me the bug is either already fixed (and should be fixed in istio once using the current version of client_golang) or something else is happening in the Istio code.