Skip to content

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented Oct 14, 2018

@grobie @stuartnelson3 let's finally do this! I'll tag once this is merged.
@krasi-georgiev Since the API client is completely independent from the instrumentation library, but both are in one repo, we will share the tagging. I thus also tried to put API client changes into the CHANGELOG.md. Hope that works for you.

This ends a long time of not really tagging versions (as it didn't
make a lot of sense - we could have tagged every commit with a new
minor release essentially). I still worked through the git log and GH
issues to create a nice CHANGELOG.md.

As dependency management tools really love version tags these days, I
plan to tag more often from now on. The ideas behind the pre-1.0
version numbers are explained in the README.md as changed in this
commit.

I also changed the issue template accordingly.

Much less confusing...

Signed-off-by: beorn7 <beorn@soundcloud.com>
@krasi-georgiev
Copy link
Contributor

krasi-georgiev commented Oct 15, 2018

@krasi-georgiev Since the API client is completely independent from the instrumentation library, but both are in one repo, we will share the tagging. I thus also tried to put API client changes into the CHANGELOG.md. Hope that works for you.

no objections.

This ends a long time of not really tagging versions (as it didn't
make a lot of sense - we could have tagged every commit with a new
minor release essentially). I still worked through the git log and GH
issues to create a nice CHANGELOG.md.

As dependency management tools really love version tags these days, I
plan to tag more often from now on. The ideas behind the pre-1.0
version numbers are explained in the README.md as changed in this
commit.

I also changed the issue template accordingly.

Signed-off-by: beorn7 <beorn@soundcloud.com>
Copy link
Member

@grobie grobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beorn7 beorn7 merged commit 1cafe34 into master Oct 15, 2018
@beorn7 beorn7 deleted the beorn7/release branch October 15, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants