Add a way to return the body of a 5xx response. #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: prometheus#479. Signed-off-by: Marcin Owsiany <marcin@owsiany.pl>
Signed-off-by: Marcin Owsiany <marcin@owsiany.pl>
|
Changes pushed, PTAL @krasi-georgiev |
Without t.Run() it is very hard to figure out which test in a table has failed. Signed-off-by: Marcin Owsiany <marcin@owsiany.pl>
There was a problem hiding this comment.
yep that is more logical, thanks!
I think after few small changes it is ready.
btw I find the tests very hard to follow and I think the https://golang.org/pkg/net/http/httptest/ should help to refactor and simplify these, but is a story for another PR for #485.
Signed-off-by: Marcin Owsiany <marcin@owsiany.pl>
|
All done and pushed, PTAL. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #479
Signed-off-by: Marcin Owsiany marcin@owsiany.pl
cc @krasi-georgiev